GetAttr - Does not return Empty Map

janimesh · September 29, 2019, 6:32am

GetAttr description mentions that if nothing is registered, an empty OpMap will be returned.

dmlc/tvm/blob/master/include/tvm/relay/op.h#L148-L155


 * \brief Get additional registered attribute about operators.
 *  If nothing has been registered, an empty OpMap will be returned.
 * \param attr_name The name of the attribute.
 * \return An OpMap of specified attr_name.
 * \tparam ValueType The type of the attribute.
 */
template <typename ValueType>
inline static OpMap<ValueType> GetAttr(const std::string& attr_name);

However, the code currently fails with a LOG(FATAL)

github.com

dmlc/tvm/blob/master/src/relay/ir/op.cc#L81-L83


if (it == mgr->attr.end()) {
  LOG(FATAL) << "Operator attribute \'" << key << "\' is not registered";
}

Wanted to check which one is correct.

@tqchen

Background - I need to put a check in Legalize, if a string has been registered. We register many ops via Python Packed Funcs. But, CC tests don’t go through python path, leading to cases where the legalize string is not registered. More specifically, I need HasAttr functionality (I prototyped it in https://github.com/dmlc/tvm/pull/3971/files), but if GetAttr can return empty map, I can work with that as well.