I spent 5hr today add a new Node

yzhliu · November 14, 2019, 2:26am

Because I forgot to do TVM_REGISTER_NODE_TYPE(XXXNode) in .cc.

If you see TVMError: Check failed: it != type_key2index_.end(): Cannot find type XXX, that’s probably the reason.

junrushao · November 14, 2019, 2:28am

Haha, thanks for sharing!

lklcf · November 14, 2019, 3:28am

Could you please write a tutorial about how to add a node from relay to topi? thanks

junrushao · November 14, 2019, 3:31am

This would be great if we can have a comprehensive tutorial

tqchen · November 14, 2019, 5:23pm

Sorry to hear that, we had comments in https://github.com/apache/incubator-tvm/blob/master/include/tvm/runtime/object.h#L129

We should add more comments to node.h

hcho3 · November 15, 2019, 7:19pm

Yes! My recent PR took lots of time because it was not obvious that TVM_REGISTER_NODE_TYPE was needed.

github.com

apache/incubator-tvm/blob/da23619a8cc05ce253c0bf8955a5549c16322468/src/relay/op/nn/nn.cc#L104


.set_support_level(1)
.add_type_rel("BiasAdd", BiasAddRel)
.set_attr<FTVMCompute>("FTVMCompute", [](const Attrs& attrs, const Array<Tensor>& inputs,
                                        const Type& out_type, const Target& target) {
    const auto* param = attrs.as<BiasAddAttrs>();
    return tvm::Array<tvm::Tensor>{topi::nn::bias_add(inputs[0], inputs[1], param->axis)};
});




// relay.nn.fifo_buffer
TVM_REGISTER_NODE_TYPE(FIFOBufferAttrs);


Expr MakeFIFOBuffer(Expr input, Expr buffer, int axis) {
  auto attrs = make_node<FIFOBufferAttrs>();
  attrs->axis = axis;
  static const Op& op = Op::Get("nn.fifo_buffer");
  return CallNode::make(op, {input, buffer}, Attrs(attrs), {});
}


bool FIFOBufferRel(const Array<Type>& types,
                   int num_inputs,

tqchen · November 16, 2019, 12:25am

@hcho3 can you take a stab to add the additional comment :)?

yzhliu · November 16, 2019, 12:33am

would it be helpful to remind about TVM_REGISTER_NODE_TYPE in the error message?

tqchen · November 16, 2019, 12:35am

That is a great idea @yzhliu