@comaniac and I are working on generating code using codegen tools outside of TVM stack: https://github.com/apache/incubator-tvm/pull/4482. We want to have some comments about the name of the attribute that indicates a Relay function will use external codegen tools. This field will be used by the runtime to lookup a symbol for execution. Some possible names in discussion are:
FuncName
, ExportFuncName
, ExtFuncName
, ExportSymbol
. Please share your idea:)
Other than FuncName, I would prefer ExportSymbol
1 Like
I would prefer ExternalSymbol
as it follows the naming convention in c++ linker.
ExternalSymbol
sounds good to me, while just putting some other names in my head, ThirdPartyExecutor
, ExtExecutor
, BringYourOwnExecutor
ExternalSymbol
or ExternalFuncName
sounds good to me!
+1 for ExternalSymbol
.
+1 for ExternalSymbol
.
Looks ExternalSymbol
is the winner. Thanks @haichen for proposing it. @tqchen any thought or comments?
Seems we are converging. I don’t have strong opinions. Let us wait a bit to give everyone including those from a different timezone to share their thoughts, then we can conclude by summarizing the discussion.